Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 2274253002: Added counters for pointer boundary events fired. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dtapuska's comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/events/EventTarget.cpp
diff --git a/third_party/WebKit/Source/core/events/EventTarget.cpp b/third_party/WebKit/Source/core/events/EventTarget.cpp
index d98bb138c288ff47c9a2f04c3a6e7e6343915351..c8de656eea1f2ad817b9e716246152ef448a1d04 100644
--- a/third_party/WebKit/Source/core/events/EventTarget.cpp
+++ b/third_party/WebKit/Source/core/events/EventTarget.cpp
@@ -588,6 +588,21 @@ bool EventTarget::fireEventListeners(Event* event, EventTargetData* d, EventList
if (event->isPointerEvent() && static_cast<PointerEvent*>(event)->pointerType() == "touch")
UseCounter::count(executingWindow->document(), UseCounter::PointerDownFiredForTouch);
}
+ } else if (checkTypeThenUseCount(event, EventTypeNames::pointerenter, UseCounter::PointerEnterLeaveFired)
+ || checkTypeThenUseCount(event, EventTypeNames::pointerleave, UseCounter::PointerEnterLeaveFired)
+ || checkTypeThenUseCount(event, EventTypeNames::pointerover, UseCounter::PointerOverOutFired)
+ || checkTypeThenUseCount(event, EventTypeNames::pointerout, UseCounter::PointerOverOutFired)) {
+ LocalDOMWindow* executingWindow = this->executingWindow();
+ Node* node = toNode();
+ if (executingWindow && node && node->getNodeType() == Node::kElementNode && event->isPointerEvent()) {
+ const Element* element = static_cast<Element*>(node);
+ const PointerEvent* pointerEvent = static_cast<PointerEvent*>(event);
+ const UseCounter::Feature feature = (event->type() == EventTypeNames::pointerenter || event->type() == EventTypeNames::pointerleave)
+ ? UseCounter::PointerEnterLeaveFiredWhileCaptured
+ : UseCounter::PointerOverOutFiredWhileCaptured;
+ if (element->hasPointerCapture(pointerEvent->pointerId()))
+ UseCounter::count(executingWindow->document(), feature);
Navid Zolghadr 2016/08/24 21:18:01 This probably won't work as you expect. In the nor
mustaq 2016/08/25 15:00:32 Yes, good catch: this will trigger when set/releas
mustaq 2016/08/25 15:45:54 Done, ptal. I didn't mark the new API as temporary
+ }
}
ExecutionContext* context = getExecutionContext();
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698