Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2274243002: Add data usage tracking for data reduction proxy, precache services (Closed)

Created:
4 years, 4 months ago by Raj
Modified:
4 years, 2 months ago
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, wifiprefetch-reviews_google.com, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add data usage tracking for data reduction proxy, precache services BUG=527304 Committed: https://crrev.com/e74a4dcf845e3302a6c65d03fb3490e3fd3626ef Cr-Commit-Position: refs/heads/master@{#421130}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added to histograms.xml #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M components/data_reduction_proxy/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use_user_data.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use_user_data.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M components/precache/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/precache/core/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/precache/core/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/precache/core/precache_fetcher.cc View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 51 (41 generated)
Raj
4 years, 4 months ago (2016-08-24 18:45:14 UTC) #2
bengr
https://codereview.chromium.org/2274243002/diff/1/components/data_use_measurement/core/data_use_user_data.h File components/data_use_measurement/core/data_use_user_data.h (right): https://codereview.chromium.org/2274243002/diff/1/components/data_use_measurement/core/data_use_user_data.h#newcode43 components/data_use_measurement/core/data_use_user_data.h:43: DATA_REDUCTION_PROXY, Please update DataUseServices in histograms.xml
4 years, 3 months ago (2016-08-26 16:53:00 UTC) #3
Raj
https://codereview.chromium.org/2274243002/diff/1/components/data_use_measurement/core/data_use_user_data.h File components/data_use_measurement/core/data_use_user_data.h (right): https://codereview.chromium.org/2274243002/diff/1/components/data_use_measurement/core/data_use_user_data.h#newcode43 components/data_use_measurement/core/data_use_user_data.h:43: DATA_REDUCTION_PROXY, On 2016/08/26 16:53:00, bengr wrote: > Please update ...
4 years, 3 months ago (2016-09-22 18:59:30 UTC) #5
bengr
lgtm. But this would be better if URLFetcher could be constructed with a label, so ...
4 years, 3 months ago (2016-09-23 20:14:06 UTC) #8
gayane -on leave until 09-2017
lgtm
4 years, 2 months ago (2016-09-26 16:06:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274243002/20001
4 years, 2 months ago (2016-09-26 16:46:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/75051)
4 years, 2 months ago (2016-09-26 16:57:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274243002/160001
4 years, 2 months ago (2016-09-27 06:33:27 UTC) #47
commit-bot: I haz the power
Committed patchset #4 (id:160001)
4 years, 2 months ago (2016-09-27 06:38:44 UTC) #49
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 06:40:09 UTC) #51
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e74a4dcf845e3302a6c65d03fb3490e3fd3626ef
Cr-Commit-Position: refs/heads/master@{#421130}

Powered by Google App Engine
This is Rietveld 408576698