Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Issue 2274233002: [Devtools] Fix reload behavior when devtools is open (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: new methods Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
index 4047ecca74a61c32b436f16d2102427259f48c6d..aaebbc3773334dcdc5abeab8616663a2e1e448c8 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
@@ -406,7 +406,12 @@ void InspectorPageAgent::reload(ErrorString*, const Maybe<bool>& optionalBypassC
m_pendingScriptToEvaluateOnLoadOnce = optionalScriptToEvaluateOnLoad.fromMaybe("");
m_v8Session->setSkipAllPauses(true);
m_reloading = true;
- m_inspectedFrames->root()->reload(optionalBypassCache.fromMaybe(false) ? FrameLoadTypeReloadBypassingCache : FrameLoadTypeReload, ClientRedirectPolicy::NotClientRedirect);
+ FrameLoadType reloadType = FrameLoadTypeReload;
+ if (optionalBypassCache.fromMaybe(false))
+ reloadType = FrameLoadTypeReloadBypassingCache;
+ else if (RuntimeEnabledFeatures::reloadwithoutSubResourceCacheRevalidationEnabled())
+ reloadType = FrameLoadTypeReloadMainResource;
+ m_inspectedFrames->root()->reload(reloadType, ClientRedirectPolicy::NotClientRedirect);
}
void InspectorPageAgent::navigate(ErrorString*, const String& url, String* outFrameId)
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698