runtime/vm/raw_object_snapshot.cc - Issue 227423005: Add TraceBuffer log to all Functions (plus small tweaks to function-view)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 227423005: Add TraceBuffer log to all Functions (plus small tweaks to function-view) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/raw_object_snapshot.cc

diff --git a/runtime/vm/raw_object_snapshot.cc b/runtime/vm/raw_object_snapshot.cc

index 08e0ecb2e5a9a3659e85a2d1d7782e806f1d9dbc..cc75e8e176e5cf9b5e1219614651f1f54a51319b 100644

--- a/runtime/vm/raw_object_snapshot.cc

+++ b/runtime/vm/raw_object_snapshot.cc

@@ -8,6 +8,7 @@

#include "vm/snapshot.h"

#include "vm/stub_code.h"

#include "vm/symbols.h"

+#include "vm/trace_buffer.h"

#include "vm/visitor.h"

namespace dart {

@@ -701,6 +702,7 @@ RawFunction* Function::ReadFrom(SnapshotReader* reader,

func.set_kind_tag(reader->Read<uint16_t>());

func.set_optimized_instruction_count(reader->Read<uint16_t>());

func.set_optimized_call_site_count(reader->Read<uint16_t>());

+ func.set_log(new TraceBuffer());

// Set all the object fields.

// TODO(5411462): Need to assert No GC can happen here, even though

« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/trace_buffer.h » ('j') | no next file with comments »