Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/function_view.html

Issue 227423005: Add TraceBuffer log to all Functions (plus small tweaks to function-view) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/vmservice/client/lib/src/elements/log_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/lib/src/elements/function_view.html
diff --git a/runtime/bin/vmservice/client/lib/src/elements/function_view.html b/runtime/bin/vmservice/client/lib/src/elements/function_view.html
index 344f0aac82ec29ff76a4e002dc25c5e43ee7153f..64dd7265986fbbd4cdb493c917c2cf74ac7bb6e5 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/function_view.html
+++ b/runtime/bin/vmservice/client/lib/src/elements/function_view.html
@@ -3,6 +3,7 @@
<link rel="import" href="code_ref.html">
<link rel="import" href="function_ref.html">
<link rel="import" href="library_ref.html">
+ <link rel="import" href="log_view.html">
<link rel="import" href="observatory_element.html">
<link rel="import" href="nav_bar.html">
<link rel="import" href="script_inset.html">
@@ -67,6 +68,10 @@
</div>
</template>
<div class="memberItem">
+ <div class="memberName">optimized</div>
+ <div class="memberValue">{{ function['optimizedCode'] != null }}</div>
+ </div>
+ <div class="memberItem">
<div class="memberName">owner</div>
<div class="memberValue">
<template if="{{ function['owner'].serviceType == 'Class' }}">
@@ -90,25 +95,27 @@
<template if="{{ function['code'] != null }}">
<div class="memberItem">
- <div class="memberName">optimized code</div>
+ <div class="memberName">unoptimized code</div>
<div class="memberValue">
<code-ref ref="{{ function['code'] }}"></code-ref>
</div>
+ <div class="memberValue">
+ <span title="This count is used to determine when a function will be optimized. It is a combination of call counts and other factors.">
+ (usage count: {{ function['usage_counter'] }})
+ </span>
+ </div>
</div>
</template>
- <template if="{{ function['unoptimized_code'] != null }}">
+
+ <template if="{{ function['optimizedCode'] != null }}">
<div class="memberItem">
- <div class="memberName">unoptimized code</div>
+ <div class="memberName">optimized code</div>
<div class="memberValue">
- <code-ref ref="{{ function['unoptimized_code'] }}"></code-ref>
+ <code-ref ref="{{ function['optimizedCode'] }}"></code-ref>
</div>
- <div class="memberValue">
- <span title="This count is used to determine when a function will be optimized. It is a combination of call counts and other factors.">
- (usage count: {{ function['usage_counter'] }})
- </span>
- </div>
- </div>
+ </div>
</template>
+
<div class="memberItem">
<div class="memberName">deoptimizations</div>
<div class="memberValue">{{ function['deoptimizations'] }}</div>
@@ -131,6 +138,9 @@
</div>
<hr>
+ <log-view log="{{ function['log'] }}"></log-view>
+
+ <hr>
<script-inset script="{{ function['script'] }}" pos="{{ function['tokenPos'] }}" endPos="{{ function['endTokenPos'] }}">
</script-inset>
« no previous file with comments | « no previous file | runtime/bin/vmservice/client/lib/src/elements/log_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698