runtime/bin/vmservice/client/lib/src/service/object.dart - Issue 227423005: Add TraceBuffer log to all Functions (plus small tweaks to function-view)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/service/object.dart

Issue 227423005: Add TraceBuffer log to all Functions (plus small tweaks to function-view) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/vmservice/client/lib/src/service/object.dart

diff --git a/runtime/bin/vmservice/client/lib/src/service/object.dart b/runtime/bin/vmservice/client/lib/src/service/object.dart

index 9024d4976ab294e5d7bfef1bb4b952cfdc5064f9..83ed0bd50c747c3fdf6a04bcc04a5436a72f2c44 100644

--- a/runtime/bin/vmservice/client/lib/src/service/object.dart

+++ b/runtime/bin/vmservice/client/lib/src/service/object.dart

@@ -730,7 +730,7 @@ class ServiceMap extends ServiceObject implements ObservableMap {

_serviceType == 'Library') &&

!_id.startsWith(objectIdRingPrefix);

}

- bool get immutable => canCache;

+ bool get immutable => canCache && (_serviceType != 'Function');

ServiceMap._empty(ServiceObjectOwner owner) : super._empty(owner);

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/log_view.html ('k') | runtime/vm/compiler.cc » ('j') | runtime/vm/deopt_instructions.cc » ('J')