Add TraceBuffer log to all Functions (plus small tweaks to function-view)

runtime/vm/deopt_instructions.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/deopt_instructions.h"
 
 #include "vm/assembler.h"
 #include "vm/code_patcher.h"
 #include "vm/intermediate_language.h"
 #include "vm/locations.h"
 #include "vm/parser.h"
 #include "vm/stack_frame.h"
+#include "vm/trace_buffer.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, compress_deopt_info, true,
             "Compress the size of the deoptimization info for optimized code.");
 DECLARE_FLAG(bool, trace_deoptimization);
 DECLARE_FLAG(bool, trace_deoptimization_verbose);
 
 
 DeoptContext::DeoptContext(const StackFrame* frame,
@@ skipping 309 matching lines @@
   FillDeferredSlots(this, &deferred_object_refs_);
 
   // Compute total number of artificial arguments used during deoptimization.
   intptr_t deopt_arg_count = 0;
   for (intptr_t i = 0; i < DeferredObjectsCount(); i++) {
     deopt_arg_count += GetDeferredObject(i)->ArgumentCount();
   }
 
   // Since this is the only step where GC can occur during deoptimization,
   // use it to report the source line where deoptimization occured.
+  DartFrameIterator iterator;
+  StackFrame* top_frame = iterator.NextFrame();
+  ASSERT(top_frame != NULL);
+  const Code& code = Code::Handle(top_frame->LookupDartCode());

[turnidge, 2014/04/14 16:41:17]

Instead of using a DartFrameIterator to get the code here, the DeoptContext has
a code() accessor -- can you see if that works instead?

[Cutch, 2014/04/15 20:47:58]

Done.

+  const Function& top_function = Function::Handle(code.function());
+  top_function.log()->TraceF("Deoptimized (reason %" Pd " '%s')",
+                              static_cast<intptr_t>(deopt_reason()),
+                              DeoptReasonToText(deopt_reason()));

[turnidge, 2014/04/14 16:41:17]

We should eventually include which code object was deoptimized in the log --
maybe add a TODO?

[Cutch, 2014/04/15 20:47:58]

Done.

+
   if (FLAG_trace_deoptimization || FLAG_trace_deoptimization_verbose) {
-    DartFrameIterator iterator;
-    StackFrame* top_frame = iterator.NextFrame();
-    ASSERT(top_frame != NULL);
-    const Code& code = Code::Handle(top_frame->LookupDartCode());
-    const Function& top_function = Function::Handle(code.function());
     const Script& script = Script::Handle(top_function.script());
     const intptr_t token_pos = code.GetTokenIndexOfPC(top_frame->pc());
     intptr_t line, column;
     script.GetTokenLocation(token_pos, &line, &column);
     String& line_string = String::Handle(script.GetLine(line));
     OS::PrintErr("  Function: %s\n", top_function.ToFullyQualifiedCString());
     OS::PrintErr("  Line %" Pd ": '%s'\n", line, line_string.ToCString());
     OS::PrintErr("  Deopt args: %" Pd "\n", deopt_arg_count);
+    top_function.log()->TraceF("Deoptimized at line %" Pd ": '%s'",
+                               line,
+                               line_string.ToCString());
   }
 
   return deopt_arg_count;
 }
 
 
 RawArray* DeoptContext::DestFrameAsArray() {
   ASSERT(dest_frame_ != NULL && dest_frame_is_allocated_);
   const Array& dest_array =
       Array::Handle(Array::New(dest_frame_size_));
@@ skipping 1111 matching lines @@
                           Smi* offset,
                           DeoptInfo* info,
                           Smi* reason) {
   intptr_t i = index * kEntrySize;
   *offset ^= table.At(i);
   *info ^= table.At(i + 1);
   *reason ^= table.At(i + 2);
 }
 
 }  // namespace dart