Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2274223003: DevTools: [shadow-editor] Make color swatches clickable for shadow properties (Closed)

Created:
4 years, 3 months ago by flandy
Modified:
4 years, 3 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [shadow-editor] Make color swatches clickable for shadow properties BUG=639095 Committed: https://crrev.com/3a26cea8fd220c2d05a146b7057e1278883934a9 Cr-Commit-Position: refs/heads/master@{#414224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js View 2 chunks +3 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 3 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
flandy
Please take a look.
4 years, 3 months ago (2016-08-24 18:42:16 UTC) #2
dgozman
lgtm
4 years, 3 months ago (2016-08-24 18:53:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274223003/1
4 years, 3 months ago (2016-08-24 22:07:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 00:36:54 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 00:38:25 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3a26cea8fd220c2d05a146b7057e1278883934a9
Cr-Commit-Position: refs/heads/master@{#414224}

Powered by Google App Engine
This is Rietveld 408576698