Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2274223002: gyp/sfntly: set SK_SFNTLY_SUBSETTER uniformly (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

gyp/sfntly: set SK_SFNTLY_SUBSETTER uniformly When Skia is built into the Android framework, SK_SFNTLY_SUBSETTER="sample/chromium/font_subsetter.h". This sets the same value for Skia's test framework I will eventually move away from the #include PREPROCESSOR_DEFINE trick, which does not work everywhere. No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/e37aa89c5c6f31e6ddf43d5e530dda4f127b0f5a

Patch Set 1 : 2016-08-24 (Wednesday) 14:14:34 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gyp/sfntly.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M include/config/SkUserConfig.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
hal.canary
ptal
4 years, 4 months ago (2016-08-24 19:15:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274223002/20001
4 years, 4 months ago (2016-08-24 19:21:17 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 4 months ago (2016-08-24 19:21:19 UTC) #11
mtklein
lgtm
4 years, 4 months ago (2016-08-24 19:22:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/13054)
4 years, 4 months ago (2016-08-24 19:22:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274223002/20001
4 years, 4 months ago (2016-08-24 19:25:40 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 19:28:43 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/e37aa89c5c6f31e6ddf43d5e530dda4f127b0f5a

Powered by Google App Engine
This is Rietveld 408576698