Implement Big-Endian eqv test for DecodeDate and DecodeValueObjects

Implement Big-Endian eqv test for DecodeDate and DecodeValueObjects

R=jkummerow@chromium.org, jbroman@chromium.org
BUG=

Committed: https://crrev.com/54f5558d52e09ba8729ca395ada270603116eeb1
Cr-Commit-Position: refs/heads/master@{#38910}

[john.yan, 2016-08-24 20:14:47]

PTAL

[jbroman, 2016-08-24 20:22:24]

Looks fine to me; sorry I forgot to guard these tests.

DecodeString, DecodeInvalidString and DecodeNumber are also missing tests for
big-endian machines (but I remembered to add preprocessor guards there). (I
didn't have one handy to verify that I'd written them correctly, so I left TODOs
instead).

https://codereview.chromium.org/2274173003/diff/1/test/unittests/value-serial...
File test/unittests/value-serializer-unittest.cc (right):

https://codereview.chromium.org/2274173003/diff/1/test/unittests/value-serial...
test/unittests/value-serializer-unittest.cc:1109: printf("val = %f\n", val);
please remove this printf (and the line before it)

[john.yan, 2016-08-24 22:32:44]

Fixed.

https://codereview.chromium.org/2274173003/diff/1/test/unittests/value-serial...
File test/unittests/value-serializer-unittest.cc (right):

https://codereview.chromium.org/2274173003/diff/1/test/unittests/value-serial...
test/unittests/value-serializer-unittest.cc:1109: printf("val = %f\n", val);
On 2016/08/24 20:22:24, jbroman wrote:
> please remove this printf (and the line before it)

Really sorry for this. The printf was intended to provide debug info.

[jbroman, 2016-08-24 23:38:14]

lgtm, but you'll need jkummerow's review as well (as I'm not a V8 owner)

https://codereview.chromium.org/2274173003/diff/1/test/unittests/value-serial...
File test/unittests/value-serializer-unittest.cc (right):

https://codereview.chromium.org/2274173003/diff/1/test/unittests/value-serial...
test/unittests/value-serializer-unittest.cc:1109: printf("val = %f\n", val);
On 2016/08/24 at 22:32:44, john.yan wrote:
> On 2016/08/24 20:22:24, jbroman wrote:
> > please remove this printf (and the line before it)
> 
> Really sorry for this. The printf was intended to provide debug info.

No need to apologize; I sometimes forget to remove debugging code too. :)

[john.yan, 2016-08-25 03:10:05]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 03:10:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 03:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 03:32:17]

Dry run: This issue passed the CQ dry run.

[john.yan, 2016-08-25 04:51:56]

On 2016/08/24 23:38:14, jbroman wrote:
> lgtm, but you'll need jkummerow's review as well (as I'm not a V8 owner)
> 
>
https://codereview.chromium.org/2274173003/diff/1/test/unittests/value-serial...
> File test/unittests/value-serializer-unittest.cc (right):
> 
>
https://codereview.chromium.org/2274173003/diff/1/test/unittests/value-serial...
> test/unittests/value-serializer-unittest.cc:1109: printf("val = %f\n", val);
> On 2016/08/24 at 22:32:44, john.yan wrote:
> > On 2016/08/24 20:22:24, jbroman wrote:
> > > please remove this printf (and the line before it)
> > 
> > Really sorry for this. The printf was intended to provide debug info.
> 
> No need to apologize; I sometimes forget to remove debugging code too. :)

Thanks for reviewing!

[Jakob Kummerow, 2016-08-25 08:31:41]

lgtm

[john.yan, 2016-08-25 14:01:59]

The CQ bit was checked by jyan@ca.ibm.com

[commit-bot: I haz the power, 2016-08-25 14:02:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 14:11:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-25 14:11:37]

Description was changed from

==========
Implement Big-Endian eqv test for DecodeDate and DecodeValueObjects

R=jkummerow@chromium.org, jbroman@chromium.org
BUG=
==========

to

==========
Implement Big-Endian eqv test for DecodeDate and DecodeValueObjects

R=jkummerow@chromium.org, jbroman@chromium.org
BUG=

Committed: https://crrev.com/54f5558d52e09ba8729ca395ada270603116eeb1
Cr-Commit-Position: refs/heads/master@{#38910}
==========

[commit-bot: I haz the power, 2016-08-25 14:11:38]

Patchset 3 (id:??) landed as
https://crrev.com/54f5558d52e09ba8729ca395ada270603116eeb1
Cr-Commit-Position: refs/heads/master@{#38910}