Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/extension_function.cc

Issue 227413008: Add the feature to retain the user gesture in the extension callback (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« extensions/browser/extension_function.h ('K') | « extensions/browser/extension_function.h ('k') | extensions/browser/extension_function_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_function.cc
===================================================================
--- extensions/browser/extension_function.cc (revision 262146)
+++ extensions/browser/extension_function.cc (working copy)
@@ -75,6 +75,7 @@
has_callback_(false),
include_incognito_(false),
user_gesture_(false),
+ retain_user_gesture_(false),
bad_message_(false),
histogram_value_(extensions::functions::UNKNOWN),
source_tab_id_(-1) {
@@ -154,7 +155,7 @@
if (!results_)
results_.reset(new base::ListValue());
- response_callback_.Run(type, *results_, GetError());
+ response_callback_.Run(type, *results_, GetError(), retain_user_gesture_);
not at google - send to devlin 2014/04/09 16:44:32 it should be "user_gesture_ && retain_user_gesture
}
UIThreadExtensionFunction::UIThreadExtensionFunction()
« extensions/browser/extension_function.h ('K') | « extensions/browser/extension_function.h ('k') | extensions/browser/extension_function_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698