Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/renderer/extensions/request_sender.cc

Issue 227413008: Add the feature to retain the user gesture in the extension callback (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: gclient sync Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/request_sender.h" 5 #include "chrome/renderer/extensions/request_sender.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/renderer/extensions/chrome_v8_context.h" 8 #include "chrome/renderer/extensions/chrome_v8_context.h"
9 #include "chrome/renderer/extensions/dispatcher.h" 9 #include "chrome/renderer/extensions/dispatcher.h"
10 #include "content/public/renderer/render_view.h" 10 #include "content/public/renderer/render_view.h"
11 #include "extensions/common/extension_messages.h" 11 #include "extensions/common/extension_messages.h"
12 #include "third_party/WebKit/public/web/WebDocument.h" 12 #include "third_party/WebKit/public/web/WebDocument.h"
13 #include "third_party/WebKit/public/web/WebFrame.h" 13 #include "third_party/WebKit/public/web/WebFrame.h"
14 #include "third_party/WebKit/public/web/WebScopedUserGesture.h"
14 #include "third_party/WebKit/public/web/WebUserGestureIndicator.h" 15 #include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
16 #include "third_party/WebKit/public/web/WebUserGestureToken.h"
15 17
16 namespace extensions { 18 namespace extensions {
17 19
18 // Contains info relevant to a pending API request. 20 // Contains info relevant to a pending API request.
19 struct PendingRequest { 21 struct PendingRequest {
20 public : 22 public :
21 PendingRequest(const std::string& name, RequestSender::Source* source) 23 PendingRequest(const std::string& name,
22 : name(name), source(source) { 24 RequestSender::Source* source,
25 blink::WebUserGestureToken token)
26 : name(name), source(source), token(token) {
23 } 27 }
24 28
25 std::string name; 29 std::string name;
26 RequestSender::Source* source; 30 RequestSender::Source* source;
31 blink::WebUserGestureToken token;
27 }; 32 };
28 33
29 RequestSender::ScopedTabID::ScopedTabID(RequestSender* request_sender, 34 RequestSender::ScopedTabID::ScopedTabID(RequestSender* request_sender,
30 int tab_id) 35 int tab_id)
31 : request_sender_(request_sender), 36 : request_sender_(request_sender),
32 tab_id_(tab_id), 37 tab_id_(tab_id),
33 previous_tab_id_(request_sender->source_tab_id_) { 38 previous_tab_id_(request_sender->source_tab_id_) {
34 request_sender_->source_tab_id_ = tab_id; 39 request_sender_->source_tab_id_ = tab_id;
35 } 40 }
36 41
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 } 96 }
92 97
93 // TODO(koz): See if we can make this a CHECK. 98 // TODO(koz): See if we can make this a CHECK.
94 if (!dispatcher_->CheckContextAccessToExtensionAPI(name, context)) 99 if (!dispatcher_->CheckContextAccessToExtensionAPI(name, context))
95 return; 100 return;
96 101
97 GURL source_url; 102 GURL source_url;
98 if (blink::WebFrame* webframe = context->web_frame()) 103 if (blink::WebFrame* webframe = context->web_frame())
99 source_url = webframe->document().url(); 104 source_url = webframe->document().url();
100 105
101 InsertRequest(request_id, new PendingRequest(name, source)); 106 InsertRequest(request_id, new PendingRequest(name, source,
107 blink::WebUserGestureIndicator::currentUserGestureToken()));
102 108
103 ExtensionHostMsg_Request_Params params; 109 ExtensionHostMsg_Request_Params params;
104 params.name = name; 110 params.name = name;
105 params.arguments.Swap(value_args); 111 params.arguments.Swap(value_args);
106 params.extension_id = context->GetExtensionID(); 112 params.extension_id = context->GetExtensionID();
107 params.source_url = source_url; 113 params.source_url = source_url;
108 params.source_tab_id = source_tab_id_; 114 params.source_tab_id = source_tab_id_;
109 params.request_id = request_id; 115 params.request_id = request_id;
110 params.has_callback = has_callback; 116 params.has_callback = has_callback;
111 params.user_gesture = 117 params.user_gesture =
112 blink::WebUserGestureIndicator::isProcessingUserGesture(); 118 blink::WebUserGestureIndicator::isProcessingUserGesture();
113 if (for_io_thread) { 119 if (for_io_thread) {
114 renderview->Send(new ExtensionHostMsg_RequestForIOThread( 120 renderview->Send(new ExtensionHostMsg_RequestForIOThread(
115 renderview->GetRoutingID(), params)); 121 renderview->GetRoutingID(), params));
116 } else { 122 } else {
117 renderview->Send(new ExtensionHostMsg_Request( 123 renderview->Send(new ExtensionHostMsg_Request(
118 renderview->GetRoutingID(), params)); 124 renderview->GetRoutingID(), params));
119 } 125 }
120 } 126 }
121 127
122 void RequestSender::HandleResponse(int request_id, 128 void RequestSender::HandleResponse(int request_id,
123 bool success, 129 bool success,
124 const base::ListValue& response, 130 const base::ListValue& response,
125 const std::string& error) { 131 const std::string& error,
132 bool user_gesture) {
126 linked_ptr<PendingRequest> request = RemoveRequest(request_id); 133 linked_ptr<PendingRequest> request = RemoveRequest(request_id);
127 134
128 if (!request.get()) { 135 if (!request.get()) {
129 // This can happen if a context is destroyed while a request is in flight. 136 // This can happen if a context is destroyed while a request is in flight.
130 return; 137 return;
131 } 138 }
132 139
140 scoped_ptr<blink::WebScopedUserGesture> gesture;
141 if (user_gesture)
142 gesture.reset(new blink::WebScopedUserGesture(request->token));
143
133 request->source->OnResponseReceived(request->name, request_id, success, 144 request->source->OnResponseReceived(request->name, request_id, success,
134 response, error); 145 response, error);
135 } 146 }
136 147
137 void RequestSender::InvalidateSource(Source* source) { 148 void RequestSender::InvalidateSource(Source* source) {
138 for (PendingRequestMap::iterator it = pending_requests_.begin(); 149 for (PendingRequestMap::iterator it = pending_requests_.begin();
139 it != pending_requests_.end();) { 150 it != pending_requests_.end();) {
140 if (it->second->source == source) 151 if (it->second->source == source)
141 pending_requests_.erase(it++); 152 pending_requests_.erase(it++);
142 else 153 else
143 ++it; 154 ++it;
144 } 155 }
145 } 156 }
146 157
147 } // namespace extensions 158 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698