Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2274053002: [turbofan] Change map to vector in loop variable analysis. (Closed)

Created:
4 years, 4 months ago by Jarin
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Change map to vector in loop variable analysis. This recovers about 50% of the regression in compilation time. BUG=chromium:638208 Committed: https://crrev.com/a5c290216602c4af5fb898bfbcc767a1d3ca4815 Cr-Commit-Position: refs/heads/master@{#38854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/compiler/loop-variable-optimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/loop-variable-optimizer.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 4 months ago (2016-08-24 05:37:01 UTC) #2
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-24 07:24:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274053002/1
4 years, 4 months ago (2016-08-24 07:40:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 08:50:54 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 08:51:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5c290216602c4af5fb898bfbcc767a1d3ca4815
Cr-Commit-Position: refs/heads/master@{#38854}

Powered by Google App Engine
This is Rietveld 408576698