Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2335)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2274013006: Converted Observatory objectstore-view element (Closed)
Patch Set: Fixed link color Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/css/shared.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index bad6c88d2d1d65ebc7b34433f7db8926e868ee76..945137e3ede53109ae651192356fe894747d7a0e 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -15,6 +15,8 @@ InboundReferencesRepository _inboundReferencesRepository
InstanceRepository _instanceRepository = new InstanceRepository();
IsolateSampleProfileRepository _isolateSampleProfileRepository
= new IsolateSampleProfileRepository();
+ObjectStoreRepository _objectstoreRepository
+ = new ObjectStoreRepository();
PortsRepository _portsRepository = new PortsRepository();
class IsolateNotFound implements Exception {
@@ -255,22 +257,30 @@ class DebuggerPage extends SimplePage {
}
}
+class ObjectStorePage extends MatchingPage {
+ ObjectStorePage(app) : super('object-store', app);
-class ObjectStorePage extends SimplePage {
- ObjectStorePage(app) : super('object-store', 'objectstore-view', app);
+ final DivElement container = new DivElement();
void _visit(Uri uri) {
super._visit(uri);
- getIsolate(uri).then((isolate) {
- isolate.getObjectStore().then((objectStore) {
- if (element != null) {
- /// Update the page.
- ObjectStoreViewElement page = element;
- page.objectStore = objectStore;
- }
- });
+ getIsolate(uri).then((isolate) async {
+ container.children = [
+ new ObjectStoreViewElement(isolate.vm, isolate,
+ app.events,
+ app.notifications,
+ _objectstoreRepository,
+ _instanceRepository)
+ ];
});
}
+
+ void onInstall() {
+ if (element == null) {
+ element = container;
+ }
+ assert(element != null);
+ }
}
class CpuProfilerPage extends MatchingPage {
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/css/shared.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698