Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2274013006: Converted Observatory objectstore-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak, Cutch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed tests #

Patch Set 3 : Fixed link color #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -94 lines) Patch
M runtime/observatory/lib/elements.dart View 1 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 chunks +20 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectstore_view.dart View 1 chunk +121 lines, -10 lines 0 comments Download
D runtime/observatory/lib/src/elements/objectstore_view.html View 1 1 chunk +0 lines, -36 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/objectstore.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/objectstore.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/objectstore.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/objectstore.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/objectstore.dart View 1 chunk +21 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/objectstore_view/element_test.dart View 1 chunk +13 lines, -14 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/objectstore_view/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/source_link/element_test.dart View 1 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-25 23:59:55 UTC) #2
rmacnak
lgtm It's not part of this change, but I notice the empty context in the ...
4 years, 3 months ago (2016-08-26 16:31:05 UTC) #3
cbernaschina
The CSS rules were not in sync between ContextRefWrapper and shared.css Fixed
4 years, 3 months ago (2016-08-26 16:44:16 UTC) #4
cbernaschina
4 years, 3 months ago (2016-08-26 16:44:33 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
4f96ad0440d1d4e50832f55ae45a40ec4233b7cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698