Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5017)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.cc

Issue 2274013003: Keeps the opt-in IME menu in lock screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/input_method_manager_impl.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
index 4944bdc67716ff8f87506bb711707037868c8cfb..f795a2d6fc63036cf452785d1d72294bb55dbf7c 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
@@ -927,15 +927,6 @@ void InputMethodManagerImpl::SetUISessionState(UISessionState new_ui_session) {
ui_session_ = new_ui_session;
if (ui_session_ == STATE_TERMINATING && candidate_window_controller_.get())
candidate_window_controller_.reset();
-
- // The expanded IME menu is only supportive with 'normal' screen type. It
- // should be deactivated when the screen type is not 'normal', and be
- // re-activated when changing back.
- if (is_ime_menu_activated_ && ui_session_ != STATE_TERMINATING) {
- FOR_EACH_OBSERVER(
- InputMethodManager::ImeMenuObserver, ime_menu_observers_,
- ImeMenuActivationChanged(ui_session_ == STATE_BROWSER_SCREEN));
- }
Shu Chen 2016/08/25 11:49:32 Per offline discussion, this logic should be moved
Azure Wei 2016/08/26 09:30:35 Done. PTAL.
}
void InputMethodManagerImpl::OnUserAddingStarted() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698