chrome/browser/browser_resources.grd - Issue 2274013002: [Signin Error Dialog] (1/3) Added necessary web components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_resources.grd

Issue 2274013002: [Signin Error Dialog] (1/3) Added necessary web components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_resources.grd

diff --git a/chrome/browser/browser_resources.grd b/chrome/browser/browser_resources.grd

index 58d75f6cd7f473b854f3ef3b2cbefe6ccbc529c4..4c27b0d9d5ee73db2af62f6df7971cefb7397c47 100644

--- a/chrome/browser/browser_resources.grd

+++ b/chrome/browser/browser_resources.grd

@@ -380,6 +380,8 @@

+ <include name="IDR_SIGNIN_ERROR_HTML" file="resources\signin_error\signin_error.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" />

tommycli 2016/08/24 17:22:52 Does this work if it's simply preprocess="true" in

Jane 2016/08/25 16:35:28 Just preprocess="true"? I got "grit.exception.Unex

+ <include name="IDR_SIGNIN_ERROR_JS" file="resources\signin_error\signin_error.js" type="BINDATA" />

« no previous file with comments | « no previous file | chrome/browser/resources/signin_error/signin_error.html » ('j') | chrome/browser/resources/signin_error/signin_error.html » ('J')