Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2274003004: Make chrome.fileManagerPrivate.getSizeStat return actual available space for Downloads. (Closed)

Created:
4 years, 4 months ago by fukino
Modified:
4 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make chrome.fileManagerPrivate.getSizeStat return actual available space for Downloads. getSizeStat() for Downloads used to return |actual available space| + |evictable Drive cache| - 512MB. To be consistent with Storage manager (chrome://settings/storage), getSizeStat() should simplly return |actual available size|. BUG=640504 TEST=manually compared the avaiable space in Files app and Storage manager. Committed: https://crrev.com/e23227790211a07cbb31d711a2a52e313f8fc0d1 Cr-Commit-Position: refs/heads/master@{#414371}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -52 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 2 chunks +2 lines, -47 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
fukino
hirono-san, could you take a look? https://codereview.chromium.org/2274003004/diff/20001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2274003004/diff/20001/chrome/app/chromeos_strings.grdp#newcode1146 chrome/app/chromeos_strings.grdp:1146: <ph name="SPACE_AVAILABLE">$1<ex>4.8 GB</ex></ph> ...
4 years, 3 months ago (2016-08-25 08:00:23 UTC) #8
hirono
lgtm!
4 years, 3 months ago (2016-08-25 08:33:22 UTC) #9
fukino
On 2016/08/25 08:33:22, hirono wrote: > lgtm! Thanks!
4 years, 3 months ago (2016-08-25 08:35:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274003004/20001
4 years, 3 months ago (2016-08-25 08:36:17 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 09:17:50 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 09:19:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e23227790211a07cbb31d711a2a52e313f8fc0d1
Cr-Commit-Position: refs/heads/master@{#414371}

Powered by Google App Engine
This is Rietveld 408576698