Chromium Code Reviews| Index: runtime/observatory/lib/src/app/page.dart |
| diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart |
| index 182eae4469978933dd92af29dd8f28f9bfe66f5e..9d243ba6216ac5973daf5adc0d41f5e8b7a09bcd 100644 |
| --- a/runtime/observatory/lib/src/app/page.dart |
| +++ b/runtime/observatory/lib/src/app/page.dart |
| @@ -284,25 +284,28 @@ class CpuProfilerPage extends MatchingPage { |
| } |
| } |
| -class TableCpuProfilerPage extends SimplePage { |
| - TableCpuProfilerPage(app) |
| - : super('profiler-table', 'cpu-profile-table', app); |
| +class TableCpuProfilerPage extends MatchingPage { |
| + TableCpuProfilerPage(app) : super('profiler-table', app); |
| + |
| + DivElement container = new DivElement(); |
|
Cutch
2016/08/24 13:53:41
this could be final right?
cbernaschina
2016/08/24 15:34:43
Done.
|
| void _visit(Uri uri) { |
| super._visit(uri); |
| getIsolate(uri).then((isolate) { |
| - if (element != null) { |
| - /// Update the page. |
| - CpuProfileTableElement page = element; |
| - page.isolate = isolate; |
| - // TODO(johnmccutchan): Provide a more general mechanism to notify |
| - // elements of URI parameter changes. Possibly via a stream off of |
| - // LocationManager. With a stream individual elements (not just pages) |
| - // could be notified. |
| - page.checkParameters(); |
| - } |
| + container.children = [ |
| + new CpuProfileTableElement(isolate.vm, isolate, app.events, |
| + app.notifications, |
| + _isolateSampleProfileRepository) |
| + ]; |
| }); |
| } |
| + |
| + void onInstall() { |
| + if (element == null) { |
| + element = container; |
| + } |
| + assert(element != null); |
| + } |
| } |
| class AllocationProfilerPage extends MatchingPage { |