Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1956)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 2273943002: VM: More refactoring of recognized methods inlining. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_arm.cc
diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc
index aac48918ebce674144099937fdf3bde8f3675288..b4e27f061715c7022d02fcfa15d60492624e1b00 100644
--- a/runtime/vm/intermediate_language_arm.cc
+++ b/runtime/vm/intermediate_language_arm.cc
@@ -5266,21 +5266,6 @@ void BinaryInt32x4OpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
LocationSummary* MathUnaryInstr::MakeLocationSummary(Zone* zone,
bool opt) const {
- if ((kind() == MathUnaryInstr::kSin) || (kind() == MathUnaryInstr::kCos)) {
- const intptr_t kNumInputs = 1;
- const intptr_t kNumTemps = TargetCPUFeatures::hardfp_supported() ? 0 : 4;
- LocationSummary* summary = new(zone) LocationSummary(
- zone, kNumInputs, kNumTemps, LocationSummary::kCall);
- summary->set_in(0, Location::FpuRegisterLocation(Q0));
- summary->set_out(0, Location::FpuRegisterLocation(Q0));
- if (!TargetCPUFeatures::hardfp_supported()) {
- summary->set_temp(0, Location::RegisterLocation(R0));
- summary->set_temp(1, Location::RegisterLocation(R1));
- summary->set_temp(2, Location::RegisterLocation(R2));
- summary->set_temp(3, Location::RegisterLocation(R3));
- }
- return summary;
- }
ASSERT((kind() == MathUnaryInstr::kSqrt) ||
(kind() == MathUnaryInstr::kDoubleSquare));
const intptr_t kNumInputs = 1;
@@ -5303,20 +5288,7 @@ void MathUnaryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
const DRegister result = EvenDRegisterOf(locs()->out(0).fpu_reg());
__ vmuld(result, val, val);
} else {
- ASSERT((kind() == MathUnaryInstr::kSin) ||
- (kind() == MathUnaryInstr::kCos));
- if (TargetCPUFeatures::hardfp_supported()) {
- __ CallRuntime(TargetFunction(), InputCount());
- } else {
- // If we aren't doing "hardfp", then we have to move the double arguments
- // to the integer registers, and take the results from the integer
- // registers.
- __ vmovrrd(R0, R1, D0);
- __ vmovrrd(R2, R3, D1);
- __ CallRuntime(TargetFunction(), InputCount());
- __ vmovdrr(D0, R0, R1);
- __ vmovdrr(D1, R2, R3);
- }
+ UNREACHABLE();
}
}
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698