Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2273883002:
Unbundle Flash on OSX. (Closed)
DescriptionUnbundle Flash on OSX.
TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub
BUG=624086
Committed: https://crrev.com/456a13f206a277bf3996eedd03f428e039b2bb8a
Cr-Commit-Position: refs/heads/master@{#414128}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by waffles@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Unbundle Flash on OSX. TEST=TBD BUG=624086 ========== to ========== Unbundle Flash on OSX. TEST=https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/edit# BUG=624086 ==========
Description was changed from ========== Unbundle Flash on OSX. TEST=https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/edit# BUG=624086 ========== to ========== Unbundle Flash on OSX. TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub BUG=624086 ==========
waffles@chromium.org changed reviewers: + laforge@chromium.org, thakis@chromium.org
laforge, thakis, PTAL This is the mac equivalent of https://codereview.chromium.org/2251923002/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thakis@chromium.org changed reviewers: + rsesek@chromium.org
I think this is good (with the additional change), but rsesek knows how the official app is packaged better than me. https://codereview.chromium.org/2273883002/diff/1/chrome/BUILD.gn File chrome/BUILD.gn (right): https://codereview.chromium.org/2273883002/diff/1/chrome/BUILD.gn#newcode264 chrome/BUILD.gn:264: "//third_party/adobe/flash:flapper_binaries", can this go away on mac now too?
https://codereview.chromium.org/2273883002/diff/1/chrome/BUILD.gn File chrome/BUILD.gn (right): https://codereview.chromium.org/2273883002/diff/1/chrome/BUILD.gn#newcode264 chrome/BUILD.gn:264: "//third_party/adobe/flash:flapper_binaries", On 2016/08/24 16:10:02, Nico wrote: > can this go away on mac now too? I think this is already inside the !is_mac starting on line 87, right?
lgtm Thanks, I missed that.
lgtm
The CQ bit was checked by waffles@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Unbundle Flash on OSX. TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub BUG=624086 ========== to ========== Unbundle Flash on OSX. TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub BUG=624086 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Unbundle Flash on OSX. TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub BUG=624086 ========== to ========== Unbundle Flash on OSX. TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub BUG=624086 Committed: https://crrev.com/456a13f206a277bf3996eedd03f428e039b2bb8a Cr-Commit-Position: refs/heads/master@{#414128} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/456a13f206a277bf3996eedd03f428e039b2bb8a Cr-Commit-Position: refs/heads/master@{#414128} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
