Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2273873002: [Offline Pages] Enable CT features by default. (Closed)

Created:
4 years, 4 months ago by dewittj
Modified:
4 years, 4 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Enable CT features by default. This is more of a kill switch than a feature flag, so it deserves to be enabled until deemed harmful. BUG= Committed: https://crrev.com/442dff39661a7a46554f9637930b8ff37f295eed Cr-Commit-Position: refs/heads/master@{#414225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/offline_pages/offline_page_feature.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Dmitry Titov
Legit failures, you can't enable your feature (kidding). Cathy and Jian are working on it. ...
4 years, 4 months ago (2016-08-24 00:39:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273873002/1
4 years, 4 months ago (2016-08-24 20:50:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 00:37:54 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 00:40:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/442dff39661a7a46554f9637930b8ff37f295eed
Cr-Commit-Position: refs/heads/master@{#414225}

Powered by Google App Engine
This is Rietveld 408576698