Chromium Code Reviews
DescriptionRevert of Refactor DoesIntersectRect into BrowserNonClientFrameView. (patchset #2 id:20001 of https://codereview.chromium.org/2262563002/ )
Reason for revert:
It looks like I broke V1 apps on Chrome OS (see crbug.com/640230) which means it's probably broken for Mus as well (though it's hard to tell) and that negates the benefit of this refactor. I'm very sad.
Original issue's description:
> Refactor DoesIntersectRect into BrowserNonClientFrameView.
>
> As far as I can tell the DoesIntersectRect implementations of
> OpaqueBrowserFrameView, BrowserNonClientFrameViewMus, and
> BrowserNonClientFrameViewAsh are all behaviorly identical but entirely
> duplicated. So I moved them all into their common base class. Nothing
> should look or act differently after this change.
>
> TEST=Check tab strip, toolbar, and window controls to make sure still work correctly.
>
> Committed: https://crrev.com/55e6cc560a8e152d26f1b69e0929c53681eeacd7
> Cr-Commit-Position: refs/heads/master@{#413514}
TBR=sky@chromium.org,msw@chromium.org,varkha@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Committed: https://crrev.com/d449eed616d0d991d72cfb3faf23763a18a4b5dd
Cr-Commit-Position: refs/heads/master@{#413898}
Patch Set 1 #Messages
Total messages: 8 (2 generated)
|