Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2273863002: Revert of Refactor DoesIntersectRect into BrowserNonClientFrameView. (Closed)

Created:
4 years, 4 months ago by Bret
Modified:
4 years, 4 months ago
Reviewers:
msw, varkha, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor DoesIntersectRect into BrowserNonClientFrameView. (patchset #2 id:20001 of https://codereview.chromium.org/2262563002/ ) Reason for revert: It looks like I broke V1 apps on Chrome OS (see crbug.com/640230) which means it's probably broken for Mus as well (though it's hard to tell) and that negates the benefit of this refactor. I'm very sad. Original issue's description: > Refactor DoesIntersectRect into BrowserNonClientFrameView. > > As far as I can tell the DoesIntersectRect implementations of > OpaqueBrowserFrameView, BrowserNonClientFrameViewMus, and > BrowserNonClientFrameViewAsh are all behaviorly identical but entirely > duplicated. So I moved them all into their common base class. Nothing > should look or act differently after this change. > > TEST=Check tab strip, toolbar, and window controls to make sure still work correctly. > > Committed: https://crrev.com/55e6cc560a8e152d26f1b69e0929c53681eeacd7 > Cr-Commit-Position: refs/heads/master@{#413514} TBR=sky@chromium.org,msw@chromium.org,varkha@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/d449eed616d0d991d72cfb3faf23763a18a4b5dd Cr-Commit-Position: refs/heads/master@{#413898}

Patch Set 1 #

Messages

Total messages: 8 (2 generated)
Bret
Created Revert of Refactor DoesIntersectRect into BrowserNonClientFrameView.
4 years, 4 months ago (2016-08-23 21:40:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273863002/1
4 years, 4 months ago (2016-08-23 21:40:39 UTC) #3
varkha
lgtm (but I am not an owner).
4 years, 4 months ago (2016-08-23 21:49:17 UTC) #4
msw
lgtm; hopefully you can reland with a fix for that issue.
4 years, 4 months ago (2016-08-23 21:50:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 23:37:56 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 23:42:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d449eed616d0d991d72cfb3faf23763a18a4b5dd
Cr-Commit-Position: refs/heads/master@{#413898}

Powered by Google App Engine
This is Rietveld 408576698