Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 227383006: Mojo: Allow dispatchers to attach PlatformHandles to the MessageInTransit on serialization. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Allow dispatchers to attach PlatformHandles to the MessageInTransit on serialization. They still won't get transmitted, and nothing is done on the deserialization end. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -83 lines) Patch
M mojo/system/dispatcher.h View 4 chunks +57 lines, -30 lines 0 comments Download
M mojo/system/dispatcher.cc View 3 chunks +41 lines, -33 lines 0 comments Download
M mojo/system/message_in_transit.h View 2 chunks +7 lines, -0 lines 0 comments Download
M mojo/system/message_in_transit.cc View 6 chunks +51 lines, -9 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.h View 1 chunk +8 lines, -5 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.cc View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-08 21:20:09 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-08 21:49:29 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-08 21:52:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/227383006/1
6 years, 8 months ago (2014-04-08 21:54:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/227383006/1
6 years, 8 months ago (2014-04-09 00:29:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/227383006/1
6 years, 8 months ago (2014-04-09 00:53:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/227383006/1
6 years, 8 months ago (2014-04-09 01:04:56 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 01:15:54 UTC) #8
Message was sent while issue was closed.
Change committed as 262580

Powered by Google App Engine
This is Rietveld 408576698