Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2273823003: GN: guard tools (except fiddle) by skia_enable_tools. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: guard tools (except fiddle) by skia_enable_tools. Our tools use third-party libraries pretty freely, some of which may not be available in other GN environments (e.g. Fuchsia). Most can also not function when Skia is built as a shared library. fiddle stands alone as the exception to both those points: it depends on only Skia, and works fine with both a shared or static library. So guard everything but fiddle with this flag skia_enable_tools, disabled when we're building for Fuchsia or when we're build a shared library. This CL has a couple of little tweaks to Fiddle to keep it working: - divorce it from :tool_utils, instead just building SkForceLinking.cpp itself; - fix up a buggy rebase_path() that was accidentally working when we depended on :tool_utils; - drop test_only: it now only requires production-code dependencies. The SkImageEncoder Create* methods need to be SK_API if we want SkForceLinking to work across .so's. Without this, SkForceLinking needs to be part of Skia; it can't be part of the application using Skia. The rest is mostly just a re-indent under if (skia_enable_tools), courtesy of gn format. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273823003 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/c095df55e86e7126b0582856720bb9177b553ff1

Patch Set 1 #

Patch Set 2 : SK_API is needed for these functions to live in another .so #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -176 lines) Patch
M BUILD.gn View 1 4 chunks +179 lines, -175 lines 0 comments Download
M include/core/SkImageEncoder.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (16 generated)
mtklein_C
4 years, 4 months ago (2016-08-24 17:45:25 UTC) #10
jcgregorio
lgtm
4 years, 4 months ago (2016-08-24 18:03:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273823003/20001
4 years, 4 months ago (2016-08-24 18:32:27 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/13049)
4 years, 4 months ago (2016-08-24 19:09:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273823003/20001
4 years, 4 months ago (2016-08-24 19:22:58 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 19:24:26 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c095df55e86e7126b0582856720bb9177b553ff1

Powered by Google App Engine
This is Rietveld 408576698