Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 2273793002: Don't fail on profile changes in GpuVideoDecoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make MSE stop lying. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/h264_parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/gpu_video_decoder.cc
diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc
index af08d234112c996242c32217b6c4f58cc13a7f0d..f86a59805d33059abbea70a2bb1d9c96486e2089 100644
--- a/media/filters/gpu_video_decoder.cc
+++ b/media/filters/gpu_video_decoder.cc
@@ -187,10 +187,9 @@ void GpuVideoDecoder::Initialize(const VideoDecoderConfig& config,
DVLOG(1) << (previously_initialized ? "Reinitializing" : "Initializing")
<< " GVD with config: " << config.AsHumanReadableString();
- // TODO(posciak): destroy and create a new VDA on codec/profile change
- // (http://crbug.com/260224).
- if (previously_initialized && (config_.profile() != config.profile())) {
- DVLOG(1) << "Codec or profile changed, cannot reinitialize.";
+ // Disallow codec changes between configuration changes.
+ if (previously_initialized && config_.codec() != config.codec()) {
+ DVLOG(1) << "Codec changed, cannot reinitialize.";
bound_init_cb.Run(false);
return;
}
« no previous file with comments | « no previous file | media/filters/h264_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698