Move policy generated files to components/policy

Move policy generated files to components/policy

Previously these were generated in a "policy" toplevel directory. Generally
components should use the GN target_gen_dir for the generated files for
consistency.

policy_proto_export.h was moved to the proto directory. DEPS files were updated
(a few rules were broadened to all of components/policy since listing
individual headers in DEPS is not helpful and makes it more difficult for
others down the road).

The rest of the changes are mechanical search-and-replace for the new paths.

TBR=dbeam for chrome/browser/ui/webui

Committed: https://crrev.com/39d6ba4eece90cc70bff87f2ecc39e5a790e1233
Cr-Commit-Position: refs/heads/master@{#414094}

[brettw, 2016-08-23 18:12:36]

brettw@chromium.org changed reviewers:
+ bartfab@chromium.org

[brettw, 2016-08-23 18:13:58]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 18:14:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 18:32:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 18:32:38]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-08-23 19:40:40]

proto_dirs

[brettw, 2016-08-23 19:40:41]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 19:41:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 20:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 20:03:05]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-08-23 21:16:54]

missed headers

[brettw, 2016-08-23 21:16:55]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 21:17:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-23 21:17:53]

Description was changed from

==========
Move policy generated files to components/policy

Previously these were generated in a "policy" toplevel directory. Generally
components should use the GN target_gen_dir for the generated files for
consistency.

policy_proto_export.h was moved to the proto directory. DEPS files were updated
(a few rules were broadened to all of components/policy since listing
individual headers in DEPS is not helpful and makes it more difficult for
others down the road).

The rest of the changes are mechanical search-and-replace for the new paths.
==========

to

==========
Move policy generated files to components/policy

Previously these were generated in a "policy" toplevel directory. Generally
components should use the GN target_gen_dir for the generated files for
consistency.

policy_proto_export.h was moved to the proto directory. DEPS files were updated
(a few rules were broadened to all of components/policy since listing
individual headers in DEPS is not helpful and makes it more difficult for
others down the road).

The rest of the changes are mechanical search-and-replace for the new paths.

TBR=dbeam for chrome/browser/ui/webui
==========

[brettw, 2016-08-23 21:17:53]

brettw@chromium.org changed reviewers:
+ dbeam@chromium.org

[brettw, 2016-08-23 21:18:17]

+dbeam TBR for header renames in chrome/browser/ui/webui

[commit-bot: I haz the power, 2016-08-23 22:46:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 22:46:54]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-08-24 06:26:04]

lgtm

kind of funky that we have files from src/components/policy and
out/<gn-dir>/components/policy via include path magic, though, no?

[brettw, 2016-08-24 16:45:04]

On 2016/08/24 06:26:04, Dan Beam wrote:
> lgtm
> 
> kind of funky that we have files from src/components/policy and
> out/<gn-dir>/components/policy via include path magic, though, no?

Not really, that's how everything else works. Everybody should be using
target_gen_dir which matches their source directory. This also isn't different
in principle than GYP, just that the naming system tries to be more rigidly
defined.

[brettw, 2016-08-24 16:45:14]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:45:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blundell, 2016-08-24 16:49:27]

On 2016/08/24 16:45:48, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

(bartfab never actually reviewed this CL...)

[commit-bot: I haz the power, 2016-08-24 16:56:56]

Description was changed from

==========
Move policy generated files to components/policy

Previously these were generated in a "policy" toplevel directory. Generally
components should use the GN target_gen_dir for the generated files for
consistency.

policy_proto_export.h was moved to the proto directory. DEPS files were updated
(a few rules were broadened to all of components/policy since listing
individual headers in DEPS is not helpful and makes it more difficult for
others down the road).

The rest of the changes are mechanical search-and-replace for the new paths.

TBR=dbeam for chrome/browser/ui/webui
==========

to

==========
Move policy generated files to components/policy

Previously these were generated in a "policy" toplevel directory. Generally
components should use the GN target_gen_dir for the generated files for
consistency.

policy_proto_export.h was moved to the proto directory. DEPS files were updated
(a few rules were broadened to all of components/policy since listing
individual headers in DEPS is not helpful and makes it more difficult for
others down the road).

The rest of the changes are mechanical search-and-replace for the new paths.

TBR=dbeam for chrome/browser/ui/webui
==========

[commit-bot: I haz the power, 2016-08-24 16:56:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-24 16:58:10]

Description was changed from

==========
Move policy generated files to components/policy

Previously these were generated in a "policy" toplevel directory. Generally
components should use the GN target_gen_dir for the generated files for
consistency.

policy_proto_export.h was moved to the proto directory. DEPS files were updated
(a few rules were broadened to all of components/policy since listing
individual headers in DEPS is not helpful and makes it more difficult for
others down the road).

The rest of the changes are mechanical search-and-replace for the new paths.

TBR=dbeam for chrome/browser/ui/webui
==========

to

==========
Move policy generated files to components/policy

Previously these were generated in a "policy" toplevel directory. Generally
components should use the GN target_gen_dir for the generated files for
consistency.

policy_proto_export.h was moved to the proto directory. DEPS files were updated
(a few rules were broadened to all of components/policy since listing
individual headers in DEPS is not helpful and makes it more difficult for
others down the road).

The rest of the changes are mechanical search-and-replace for the new paths.

TBR=dbeam for chrome/browser/ui/webui

Committed: https://crrev.com/39d6ba4eece90cc70bff87f2ecc39e5a790e1233
Cr-Commit-Position: refs/heads/master@{#414094}
==========

[commit-bot: I haz the power, 2016-08-24 16:58:12]

Patchset 3 (id:??) landed as
https://crrev.com/39d6ba4eece90cc70bff87f2ecc39e5a790e1233
Cr-Commit-Position: refs/heads/master@{#414094}

[brettw, 2016-08-24 17:44:34]

On 2016/08/24 16:58:12, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/39d6ba4eece90cc70bff87f2ecc39e5a790e1233
> Cr-Commit-Position: refs/heads/master@{#414094}

Oops, I thought dbeam was another policy owner!

[brettw, 2016-08-24 17:49:10]

I'll email all the policy owners and see what they want me to do. This is >200
files which is making me worried about conflicts and they're all in MUN, so I
would prefer to avoid another day of latency.

[Shuhei Takahashi, 2016-08-25 09:16:19]

On 2016/08/24 17:49:10, brettw (ping on IM after 24h) wrote:
> I'll email all the policy owners and see what they want me to do. This is >200
> files which is making me worried about conflicts and they're all in MUN, so I
> would prefer to avoid another day of latency.

This change seems to have caused Chrome OS build failure. Please see
http://crbug.com/640896.

[blundell, 2016-08-25 09:19:38]

On 2016/08/24 17:49:10, brettw (ping on IM after 24h) wrote:
> I'll email all the policy owners and see what they want me to do. This is >200
> files which is making me worried about conflicts and they're all in MUN, so I
> would prefer to avoid another day of latency.

SGTM, thanks

[johnme, 2016-08-30 18:18:01]

This change may have broken https://goto.google.com/dfeze

[bartfab (slow), 2016-08-31 08:29:05]

On 2016/08/30 18:18:01, johnme wrote:
> This change may have broken https://goto.google.com/dfeze

It also broke YAPS. The fix was just a matter of adjusting proto include paths
though.