Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2273753002:
CMake: require libjpeg-turbo, not libjpeg (Closed)
DescriptionCMake: require libjpeg-turbo, not libjpeg
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273753002
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Committed: https://skia.googlesource.com/skia/+/d805f20c8de2164c6f665535e3c278ddfdc6e294
Patch Set 1 #Patch Set 2 : version check using pkg-config #Messages
Total messages: 24 (17 generated)
Description was changed from ========== CMake: require libjpeg-turbo, not libjpeg BUG=skia: ========== to ========== CMake: require libjpeg-turbo, not libjpeg BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273753002 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot ==========
Description was changed from ========== CMake: require libjpeg-turbo, not libjpeg BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273753002 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot ========== to ========== CMake: require libjpeg-turbo, not libjpeg Despite [http://www.libjpeg-turbo.org/About/TurboJPEG], turbojpeg.h is the only header we can use to distinguish libjpeg-turbo from libjpeg. It's present in -turbo but not in the original. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273753002 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
There were warnings when CQ was processing your CL: * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with these tests: ['defaulttests']
There were warnings when CQ was processing your CL: * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with these tests: ['defaulttests']
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
There were warnings when CQ was processing your CL: * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with these tests: ['defaulttests']
There were warnings when CQ was processing your CL: * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with these tests: ['defaulttests']
The CQ bit was unchecked by mtklein@chromium.org
Description was changed from ========== CMake: require libjpeg-turbo, not libjpeg Despite [http://www.libjpeg-turbo.org/About/TurboJPEG], turbojpeg.h is the only header we can use to distinguish libjpeg-turbo from libjpeg. It's present in -turbo but not in the original. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273753002 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot ========== to ========== CMake: require libjpeg-turbo, not libjpeg BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273753002 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot ==========
mtklein@chromium.org changed reviewers: + msarett@google.com
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-08-23 23:53 UTC
There were warnings when CQ was processing your CL: * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with these tests: ['defaulttests']
LGTM
There were warnings when CQ was processing your CL: * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot, per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with these tests: ['defaulttests']
Message was sent while issue was closed.
Description was changed from ========== CMake: require libjpeg-turbo, not libjpeg BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273753002 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot ========== to ========== CMake: require libjpeg-turbo, not libjpeg BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273753002 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/d805f20c8de2164c6f665535e3c278ddfdc6e294 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/d805f20c8de2164c6f665535e3c278ddfdc6e294 |
