Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2273733002: Use border-box as the reference box for (-webkit-)clip-path (Closed)

Created:
4 years, 4 months ago by fs
Modified:
4 years, 4 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use border-box as the reference box for (-webkit-)clip-path The 'clip-path' property should use the border box as the reference box (per default; <geometry-box> not yet supported) [1]. The new behavior matches WebKit and Gecko (except for inline boxes, see below.) For inline boxes that span multiple lines we use the union of all the lines. The test css3/masking/clip-path-reference-box-inline.html added to track this behavior. [1] https://drafts.fxtf.org/css-masking-1/#the-clip-path BUG=418484 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/70b5b81d191f2cf8057f5609ed1e53ee392f7ea1 Cr-Commit-Position: refs/heads/master@{#414118}

Patch Set 1 #

Patch Set 2 : TestExpectations #

Patch Set 3 : New baselines #

Patch Set 4 : Improved fidelity #

Patch Set 5 : New baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, --2 lines) Patch
M third_party/WebKit/LayoutTests/css3/masking/clip-path-circle-relative-overflow-expected.png View 1 2 4 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-box-1.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-box-1-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-box-2.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-box-2-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-box-3.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-box-3-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-box-inline.html View 1 chunk +19 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/masking/clip-path-reference-box-inline-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 2 3 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (22 generated)
fs
4 years, 4 months ago (2016-08-23 20:50:33 UTC) #12
fs
On 2016/08/23 at 20:50:33, fs wrote: > Finns i sjön
4 years, 4 months ago (2016-08-24 16:04:08 UTC) #22
Stephen Chennney
LGTM. Sorry for the delay (took a day off).
4 years, 4 months ago (2016-08-24 18:29:09 UTC) #23
fs
On 2016/08/24 at 18:29:09, schenney wrote: > LGTM. Sorry for the delay (took a day ...
4 years, 4 months ago (2016-08-24 19:16:43 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273733002/80001
4 years, 4 months ago (2016-08-24 19:17:47 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-24 19:29:32 UTC) #27
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 19:30:50 UTC) #29
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/70b5b81d191f2cf8057f5609ed1e53ee392f7ea1
Cr-Commit-Position: refs/heads/master@{#414118}

Powered by Google App Engine
This is Rietveld 408576698