Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: components/os_crypt/key_storage_libsecret.h

Issue 2273723002: Migrate Libsecret for OSCrypt to a new schema (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed generated password's attributes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/os_crypt/key_storage_libsecret.h
diff --git a/components/os_crypt/key_storage_libsecret.h b/components/os_crypt/key_storage_libsecret.h
index 2560b5440bbdb2c3a23394a58583b0bdd4d7fbc4..42ce9731cbec0050a4ff0e55ffdee92d48b79232 100644
--- a/components/os_crypt/key_storage_libsecret.h
+++ b/components/os_crypt/key_storage_libsecret.h
@@ -26,6 +26,12 @@ class KeyStorageLibsecret : public KeyStorageLinux {
private:
std::string AddRandomPasswordInLibsecret();
+ // TODO(crbug/639298) We begun storing passwords with a problematic schema.
Lei Zhang 2016/08/26 21:33:56 How about something like: Older Chromium releases
Lei Zhang 2016/08/26 21:33:56 Can you put crbug.com so one can more easily paste
cfroussios 2016/08/29 09:58:42 Done.
cfroussios 2016/08/29 09:58:42 Done.
+ // Here, we detect entries with the old schema and migrate them to the new
+ // schema.
+ // Returns the migrated password or an empty string if none we migrated.
+ std::string Migrate();
+
DISALLOW_COPY_AND_ASSIGN(KeyStorageLibsecret);
};
« no previous file with comments | « no previous file | components/os_crypt/key_storage_libsecret.cc » ('j') | components/os_crypt/key_storage_libsecret.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698