Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2273713002: 📰Use the scroll offset to stop the card from peeking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index 470b6310afc64e7977b44c679e0d8444d520609f..b34889d45936e2260027d8324443a90f345335e3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -519,8 +519,7 @@ public void onScrolled(RecyclerView recyclerView, int dx, int dy) {
mRecyclerView.postDelayed(mSnapScrollRunnable, SNAP_SCROLL_DELAY_MS);
}
updateSearchBoxOnScroll();
- mRecyclerView.updatePeekingCard();
- mRecyclerView.updateSnippetsHeaderDisplay();
+ mRecyclerView.updatePeekingCardAndHeader();
}
});
@@ -860,8 +859,7 @@ public void onLayoutChange(View v, int left, int top, int right, int bottom,
updateSearchBoxOnScroll();
if (mUseCardsUi) {
- mRecyclerView.updatePeekingCard();
- mRecyclerView.updateSnippetsHeaderDisplay();
+ mRecyclerView.updatePeekingCardAndHeader();
// The positioning of elements may have been changed (since the elements expand to fill
// the available vertical space), so adjust the scroll.
mRecyclerView.snapScroll(mSearchBoxView, getVerticalScroll(), getHeight());
@@ -1136,10 +1134,7 @@ protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
}
super.onMeasure(widthMeasureSpec, heightMeasureSpec);
- if (mUseCardsUi) {
- mRecyclerView.updatePeekingCard();
- mRecyclerView.updateSnippetsHeaderDisplay();
- }
+ if (mUseCardsUi) mRecyclerView.updatePeekingCardAndHeader();
}
@Override

Powered by Google App Engine
This is Rietveld 408576698