Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2273703004: Don't attempt to get SwiftShader from component updater on x86-64. (Closed)

Created:
4 years, 3 months ago by jbauman
Modified:
4 years, 3 months ago
Reviewers:
Sorin Jianu, piman
CC:
chromium-reviews, waffles
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't attempt to get SwiftShader from component updater on x86-64. The Swiftshader component is 32-bit only and doesn't work there (though it shouldn't really hurt to have it around). Committed: https://crrev.com/22db31fd2d3c0ecfe4661b092d64c106af1f561f Cr-Commit-Position: refs/heads/master@{#414324}

Patch Set 1 #

Patch Set 2 : fix header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/component_updater/swiftshader_component_installer.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (15 generated)
jbauman
piman@: please review sorin@: OWNERS review Thanks.
4 years, 3 months ago (2016-08-25 00:42:41 UTC) #11
piman
lgtm
4 years, 3 months ago (2016-08-25 00:57:46 UTC) #12
Sorin Jianu
lgtm Thank you!
4 years, 3 months ago (2016-08-25 01:30:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273703004/20001
4 years, 3 months ago (2016-08-25 01:33:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/286194)
4 years, 3 months ago (2016-08-25 02:33:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273703004/20001
4 years, 3 months ago (2016-08-25 03:50:53 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 05:35:49 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 05:37:35 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22db31fd2d3c0ecfe4661b092d64c106af1f561f
Cr-Commit-Position: refs/heads/master@{#414324}

Powered by Google App Engine
This is Rietveld 408576698