Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp

Issue 2273703002: Force events to be non blocking if main thread is unresponsive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add tests, fix bugs. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp
diff --git a/third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp b/third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp
index 4dea09b19b6641ad3e27c426b9559204786db331..62095a1bcde1b86bbbcd051c0797907e044cb685 100644
--- a/third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp
+++ b/third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp
@@ -36,11 +36,10 @@ class PerformanceMonitorTest : public ::testing::Test {
void didProcessTask() { m_monitor->didProcessTask(); }
- // scheduler::TaskTimeObserver implementation
- void ReportTaskTime(scheduler::TaskQueue* queue,
- double startTime,
- double endTime) {
- m_monitor->ReportTaskTime(queue, startTime, endTime);
+ void ReportTaskEndTime(scheduler::TaskQueue* queue,
+ double startTime,
+ double endTime) {
+ m_monitor->ReportTaskEndTime(queue, startTime, endTime);
}
String frameContextURL();
@@ -80,7 +79,7 @@ TEST_F(PerformanceMonitorTest, SingleScriptInTask) {
willExecuteScript(executionContext());
EXPECT_EQ(1, numUniqueFrameContextsSeen());
didProcessTask();
- ReportTaskTime(nullptr, 3719349.445172, 3719349.5561923); // Long task
+ ReportTaskEndTime(nullptr, 3719349.445172, 3719349.5561923); // Long task
EXPECT_EQ(1, numUniqueFrameContextsSeen());
EXPECT_EQ("https://example.com/foo", frameContextURL());
}
@@ -95,7 +94,7 @@ TEST_F(PerformanceMonitorTest, MultipleScriptsInTask_SingleContext) {
willExecuteScript(executionContext());
EXPECT_EQ(1, numUniqueFrameContextsSeen());
didProcessTask();
- ReportTaskTime(nullptr, 3719349.445172, 3719349.5561923); // Long task
+ ReportTaskEndTime(nullptr, 3719349.445172, 3719349.5561923); // Long task
EXPECT_EQ(1, numUniqueFrameContextsSeen());
EXPECT_EQ("https://example.com/foo", frameContextURL());
}
@@ -110,7 +109,7 @@ TEST_F(PerformanceMonitorTest, MultipleScriptsInTask_MultipleContexts) {
willExecuteScript(anotherExecutionContext());
EXPECT_EQ(2, numUniqueFrameContextsSeen());
didProcessTask();
- ReportTaskTime(nullptr, 3719349.445172, 3719349.5561923); // Long task
+ ReportTaskEndTime(nullptr, 3719349.445172, 3719349.5561923); // Long task
EXPECT_EQ(2, numUniqueFrameContextsSeen());
EXPECT_EQ("", frameContextURL());
}
@@ -119,10 +118,10 @@ TEST_F(PerformanceMonitorTest, NoScriptInLongTask) {
willProcessTask();
willExecuteScript(executionContext());
didProcessTask();
- ReportTaskTime(nullptr, 3719349.445172, 3719349.445182);
+ ReportTaskEndTime(nullptr, 3719349.445172, 3719349.445182);
willProcessTask();
didProcessTask();
- ReportTaskTime(nullptr, 3719349.445172, 3719349.5561923); // Long task
+ ReportTaskEndTime(nullptr, 3719349.445172, 3719349.5561923); // Long task
// Without presence of Script, FrameContext URL is not available
EXPECT_EQ(0, numUniqueFrameContextsSeen());
}

Powered by Google App Engine
This is Rietveld 408576698