third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp - Issue 2273703002: Force events to be non blocking if main thread is unresponsive.

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp

Issue 2273703002: Force events to be non blocking if main thread is unresponsive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp b/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp

index ba29066fe0013a71b59187dfea7e6cb6be320381..d923b767d9e914f59c403fe7ec7e576a0a7f13e6 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp

@@ -73,8 +73,8 @@ TEST_F(InspectorWebPerfAgentTest, SingleScriptInTask) {

EXPECT_EQ(1, numUniqueFrameContextsSeen());

m_agent->didExecuteScript();

m_agent->didProcessTask();

- m_agent->ReportTaskTime(nullptr, 3719349.445172,

- 3719349.5561923); // Long task

+ m_agent->ReportTaskEndTime(nullptr, 3719349.445172,

+ 3719349.5561923); // Long task

EXPECT_EQ(1, numUniqueFrameContextsSeen());

EXPECT_EQ("https://example.com/foo", frameContextURL());

}

@@ -91,8 +91,8 @@ TEST_F(InspectorWebPerfAgentTest, MultipleScriptsInTask_SingleContext) {

EXPECT_EQ(1, numUniqueFrameContextsSeen());

m_agent->didExecuteScript();

m_agent->didProcessTask();

- m_agent->ReportTaskTime(nullptr, 3719349.445172,

- 3719349.5561923); // Long task

+ m_agent->ReportTaskEndTime(nullptr, 3719349.445172,

+ 3719349.5561923); // Long task

EXPECT_EQ(1, numUniqueFrameContextsSeen());

EXPECT_EQ("https://example.com/foo", frameContextURL());

}

@@ -109,8 +109,8 @@ TEST_F(InspectorWebPerfAgentTest, MultipleScriptsInTask_MultipleContexts) {

EXPECT_EQ(2, numUniqueFrameContextsSeen());

m_agent->didExecuteScript();

m_agent->didProcessTask();

- m_agent->ReportTaskTime(nullptr, 3719349.445172,

- 3719349.5561923); // Long task

+ m_agent->ReportTaskEndTime(nullptr, 3719349.445172,

+ 3719349.5561923); // Long task

EXPECT_EQ(2, numUniqueFrameContextsSeen());

EXPECT_EQ("", frameContextURL());

}

@@ -120,11 +120,11 @@ TEST_F(InspectorWebPerfAgentTest, NoScriptInLongTask) {

m_agent->willExecuteScript(executionContext());

m_agent->didExecuteScript();

m_agent->didProcessTask();

- m_agent->ReportTaskTime(nullptr, 3719349.445172, 3719349.445182);

+ m_agent->ReportTaskEndTime(nullptr, 3719349.445172, 3719349.445182);

m_agent->willProcessTask();

m_agent->didProcessTask();

- m_agent->ReportTaskTime(nullptr, 3719349.445172,

- 3719349.5561923); // Long task

+ m_agent->ReportTaskEndTime(nullptr, 3719349.445172,

+ 3719349.5561923); // Long task

// Without presence of Script, FrameContext URL is not available

EXPECT_EQ(0, numUniqueFrameContextsSeen());

}