third_party/WebKit/Source/modules/webgl/WebGLObject.h - Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLObject.h

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: style Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.idl ('k') | third_party/WebKit/Source/modules/webgl/WebGLProgram.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLObject.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLObject.h b/third_party/WebKit/Source/modules/webgl/WebGLObject.h

index 6fe0442298e365e767876869325286932dc2abce..88c9dd954ac70324864e1c958022f98675244e57 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLObject.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLObject.h

@@ -26,6 +26,7 @@

#ifndef WebGLObject_h

#define WebGLObject_h

+#include "bindings/core/v8/DOMWrapperWorld.h"

#include "bindings/core/v8/ScriptWrappable.h"

#include "platform/heap/Handle.h"

#include "third_party/khronos/GLES2/gl2.h"

@@ -80,6 +81,10 @@ public:

DEFINE_INLINE_VIRTUAL_TRACE() { }

protected:

+ // To allow WebGL[2]RenderingContextBase to call visitChildDOMWrappers.

+ friend class WebGLRenderingContextBase;

+ friend class WebGL2RenderingContextBase;

explicit WebGLObject(WebGLRenderingContextBase*);

// deleteObjectImpl should be only called once to delete the OpenGL resource.

@@ -93,6 +98,8 @@ protected:

virtual gpu::gles2::GLES2Interface* getAGLInterface() const = 0;

+ virtual void visitChildDOMWrappers(v8::Isolate*, const v8::Persistent<v8::Object>&) { }

private:

unsigned m_attachmentCount;

bool m_deleted;