third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h - Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: style Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLBuffer.idl ('k') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

index b068f8713ac9629091ce4a9bd65cf9d219388153..792c773e5b07fe710bb2175a07a13434ac4a342a 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

@@ -26,7 +26,6 @@

#ifndef WebGLFramebuffer_h

#define WebGLFramebuffer_h

-#include "bindings/core/v8/ScopedPersistent.h"

#include "modules/webgl/WebGLContextObject.h"

#include "modules/webgl/WebGLSharedObject.h"

@@ -95,7 +94,7 @@ public:

GLenum getReadBuffer() const { return m_readBuffer; }

- ScopedPersistent<v8::Array>* getPersistentCache();

+ virtual void visitChildDOMWrappers(v8::Isolate*, const v8::Persistent<v8::Object>&);

DECLARE_VIRTUAL_TRACE();

@@ -130,8 +129,6 @@ private:

Vector<GLenum> m_filteredDrawBuffers;

GLenum m_readBuffer;

- ScopedPersistent<v8::Array> m_attachmentWrappers;

};

} // namespace blink