third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp - Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + address Ken's comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/modules/v8/custom/V8WebGLRenderingContextCustom.cpp ('K') | « third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.idl » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

index 0401fe7f747e97c2c386a25d5d09a0fd216714b4..c16f55982685dabcb337c142534713aa17bc4589 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

@@ -422,9 +422,11 @@ GLenum WebGLFramebuffer::getDrawBuffer(GLenum drawBuffer)

return GL_NONE;

}

-ScopedPersistent<v8::Array>* WebGLFramebuffer::getPersistentCache()

+void WebGLFramebuffer::visitChildDOMWrappers(v8::Isolate* isolate, const v8::Persistent<v8::Object>& wrapper)

{

- return &m_attachmentWrappers;

+ for (const auto& kv : m_attachments) {

haraken 2016/09/02 19:08:41 kv => attachement Blink prefers a fully qualified

Kai Ninomiya 2016/09/03 01:02:05 Done.

+ DOMWrapperWorld::setWrapperReferencesInAllWorlds(wrapper, kv.value->object(), isolate);

+ }

}

DEFINE_TRACE(WebGLFramebuffer)