third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp - Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + address Ken's comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h » ('j') | third_party/WebKit/Source/bindings/modules/v8/custom/V8WebGL2RenderingContextCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

index 3c6dee4d4a0da832b3405b4dc9b8524a6037b4d3..e9fec1d0042dd10dca0f442984ad1f1a05fb5561 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

@@ -161,6 +161,8 @@ void DOMWrapperWorld::markWrappersInAllWorlds(ScriptWrappable* scriptWrappable,

void DOMWrapperWorld::setWrapperReferencesInAllWorlds(const v8::Persistent<v8::Object>& parent, ScriptWrappable* scriptWrappable, v8::Isolate* isolate)

{

+ if (!scriptWrappable)

+ return;

// Marking for the main world

if (scriptWrappable->containsWrapper())

scriptWrappable->setReference(parent, isolate);