third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp - Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webgl/WebGLObject.h ('K') | « third_party/WebKit/Source/modules/webgl/WebGLProgram.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLProgram.idl » ('j') | third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp b/third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp

index d113ab08ed92246a19c4d720c02706dc3f265b12..c5dea3606c17a45040ce97f2cbe569feb49e5202 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp

@@ -147,9 +147,11 @@ bool WebGLProgram::detachShader(WebGLShader* shader)

}

-ScopedPersistent<v8::Array>* WebGLProgram::getPersistentCache()

+void WebGLProgram::visitChildDOMWrappers(v8::Isolate* isolate, const v8::Persistent<v8::Object>& wrapper)

{

- return &m_shaderWrappers;

+ trySetWrapperReferencesInAllWorlds(wrapper, this, isolate);

Ken Russell (switch to Gerrit) 2016/09/01 21:03:53 Same here.

Kai Ninomiya 2016/09/02 18:29:22 Done.

+ trySetWrapperReferencesInAllWorlds(wrapper, m_vertexShader, isolate);

+ trySetWrapperReferencesInAllWorlds(wrapper, m_fragmentShader, isolate);

}

void WebGLProgram::cacheInfoIfNeeded(WebGLRenderingContextBase* context)