Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
index 0401fe7f747e97c2c386a25d5d09a0fd216714b4..23dde2caa7b7524b76148aba1d819a5da5354bbb 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
@@ -422,9 +422,13 @@ GLenum WebGLFramebuffer::getDrawBuffer(GLenum drawBuffer)
return GL_NONE;
}
-ScopedPersistent<v8::Array>* WebGLFramebuffer::getPersistentCache()
+void WebGLFramebuffer::visitChildDOMWrappers(v8::Isolate* isolate, const v8::Persistent<v8::Object>& wrapper)
{
- return &m_attachmentWrappers;
+ trySetWrapperReferencesInAllWorlds(wrapper, this, isolate);
Ken Russell (switch to Gerrit) 2016/09/01 21:03:53 I'd suggest leaving this responsibility to the cal
Kai Ninomiya 2016/09/02 18:29:22 Done.
+
+ for (const auto& kv : m_attachments) {
+ trySetWrapperReferencesInAllWorlds(wrapper, kv.value->object(), isolate);
+ }
}
DEFINE_TRACE(WebGLFramebuffer)

Powered by Google App Engine
This is Rietveld 408576698