third_party/WebKit/Source/bindings/templates/interface.cpp - Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.cpp

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/IDLExtendedAttributes.md ('K') | « third_party/WebKit/Source/bindings/templates/interface.h ('k') | third_party/WebKit/Source/modules/webgl/OESVertexArrayObject.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/interface.cpp b/third_party/WebKit/Source/bindings/templates/interface.cpp

index 560f309b85525392861e6eab2098963d2a93974a..00b3c65fab50f4d545cf2fdc9ed678bc75791fc2 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.cpp

+++ b/third_party/WebKit/Source/bindings/templates/interface.cpp

@@ -566,6 +566,9 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* scriptWrappable, const v8::Persistent<v8::Object>& wrapper)

{

{{cpp_class}}* impl = scriptWrappable->toImpl<{{cpp_class}}>();

+ {% if has_visit_dom_wrapper_extra %}

+ {{v8_class}}::visitDOMWrapperExtra(isolate, impl, wrapper);

+ {% endif %}

{% if set_wrapper_reference_to %}

{{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = impl->{{set_wrapper_reference_to.name}}();

if ({{set_wrapper_reference_to.name}}) {