Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
index aa6723d214d340475d7859480e1280df5e147fd4..87f82a493c5b940203101a3ecbbdefe609d1027f 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
@@ -209,9 +209,13 @@ def interface_context(interface):
}
set_wrapper_reference_to['idl_type'].add_includes_for_type()
+ # [Custom=VisitDOMWrapperExtra]
+ has_visit_dom_wrapper_extra = has_extended_attribute_value(interface, 'Custom', 'VisitDOMWrapperExtra')
+
# [Custom=VisitDOMWrapper]
has_visit_dom_wrapper = (
has_extended_attribute_value(interface, 'Custom', 'VisitDOMWrapper') or
+ has_visit_dom_wrapper_extra or
set_wrapper_reference_from or set_wrapper_reference_to)
wrapper_class_id = ('NodeClassId' if inherits_interface(interface.name, 'Node') else 'ObjectClassId')
@@ -237,6 +241,7 @@ def interface_context(interface):
'has_custom_legacy_call_as_function': has_extended_attribute_value(interface, 'Custom', 'LegacyCallAsFunction'), # [Custom=LegacyCallAsFunction]
'has_partial_interface': len(interface.partial_interfaces) > 0,
'has_visit_dom_wrapper': has_visit_dom_wrapper,
+ 'has_visit_dom_wrapper_extra': has_visit_dom_wrapper_extra,
'header_includes': header_includes,
'interface_name': interface.name,
'is_array_buffer_or_view': is_array_buffer_or_view,

Powered by Google App Engine
This is Rietveld 408576698