Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8WebGLRenderingContextCustom.cpp

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/custom/V8WebGLRenderingContextCustom.cpp
diff --git a/third_party/WebKit/public/platform/WebEffectiveConnectionType.h b/third_party/WebKit/Source/bindings/modules/v8/custom/V8WebGLRenderingContextCustom.cpp
similarity index 79%
copy from third_party/WebKit/public/platform/WebEffectiveConnectionType.h
copy to third_party/WebKit/Source/bindings/modules/v8/custom/V8WebGLRenderingContextCustom.cpp
index 3a962660065362001ceb20332a6ddb04523be96a..c7accf8b8c25587f0e2d087f134a5c0453e8cfda 100644
--- a/third_party/WebKit/public/platform/WebEffectiveConnectionType.h
+++ b/third_party/WebKit/Source/bindings/modules/v8/custom/V8WebGLRenderingContextCustom.cpp
@@ -28,20 +28,18 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebEffectiveConnectionType_h
-#define WebEffectiveConnectionType_h
+#include "bindings/modules/v8/V8WebGLRenderingContext.h"
+
+#include "modules/webgl/WebGLRenderingContextBase.h"
+
+using namespace WTF;
namespace blink {
-enum class WebEffectiveConnectionType {
- TypeUnknown,
- TypeOffline,
- TypeSlow2G,
- Type2G,
- Type3G,
- Type4G
-};
+void V8WebGLRenderingContext::visitDOMWrapperExtra(v8::Isolate* isolate, ScriptWrappable* scriptWrappable, const v8::Persistent<v8::Object>& wrapper)
+{
+ WebGLRenderingContext* impl = scriptWrappable->toImpl<WebGLRenderingContext>();
+ impl->visitChildDOMWrappers(isolate, wrapper);
+}
} // namespace blink
-
-#endif // WebEffectiveConnectionType_h

Powered by Google App Engine
This is Rietveld 408576698