Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: media/audio/audio_manager_base.cc

Issue 2273653002: Add groupid for media devices. Group audio devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename variables Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_manager_base.cc
diff --git a/media/audio/audio_manager_base.cc b/media/audio/audio_manager_base.cc
index bfca277e7312dcf4bfafbe188d953659876009a8..eb9f06c3335368118231890e1abb670a933db98b 100644
--- a/media/audio/audio_manager_base.cc
+++ b/media/audio/audio_manager_base.cc
@@ -345,6 +345,26 @@ std::string AudioManagerBase::GetAssociatedOutputDeviceID(
return "";
}
+std::string AudioManagerBase::GetGroupIDOutput(std::string output_device_id) {
+ if (output_device_id == AudioDeviceDescription::kDefaultDeviceId) {
+ std::string real_device_id = GetDefaultOutputDeviceID();
+ if (!real_device_id.empty()) {
+ return real_device_id;
+ }
+ }
+ return output_device_id;
+}
+
+std::string AudioManagerBase::GetGroupIDInput(std::string input_device_id) {
+ std::string output_device_id = GetAssociatedOutputDeviceID(input_id);
tommi (sloooow) - chröme 2016/08/29 16:19:53 what is input_id? (does this compile?)
Max Morin 2016/08/30 08:17:45 Done.
+ if (output_device_id.empty()) {
+ // Some characters are added to avoid accidentally
+ // giving the input the same group id as an output.
+ return input_device_id + "input";
+ }
+ return GetGroupIDOutput(output_device_id);
+}
+
std::string AudioManagerBase::GetDefaultOutputDeviceID() {
return "";
}

Powered by Google App Engine
This is Rietveld 408576698