Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2273613003: Add a null check for last committed entry in ClassifyNavigation. (Closed)

Created:
4 years, 4 months ago by Charlie Reis
Modified:
4 years, 4 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a null check for last committed entry in ClassifyNavigation. BUG=640429 TEST=No more ClassifyNavigation crashes. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/5eb00a5f409b89783ee1685a7c59786727d31aeb Cr-Commit-Position: refs/heads/master@{#413973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Charlie Reis
Nasko: Mind reviewing? I stumbled across these crash reports, which we should prevent. (I wasn't ...
4 years, 4 months ago (2016-08-24 00:53:59 UTC) #5
nasko
LGTM
4 years, 4 months ago (2016-08-24 03:02:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273613003/1
4 years, 4 months ago (2016-08-24 03:04:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 03:50:45 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 03:52:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5eb00a5f409b89783ee1685a7c59786727d31aeb
Cr-Commit-Position: refs/heads/master@{#413973}

Powered by Google App Engine
This is Rietveld 408576698