Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2273563002: MD History: Fix content sidebar in RTL languages (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
calamity, Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix content sidebar in RTL languages BUG=640100 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/resources/md_history/app.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tsergeant
4 years, 4 months ago (2016-08-23 07:24:08 UTC) #3
Dan Beam
wanna race? lgtm
4 years, 4 months ago (2016-08-23 23:14:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273563002/1
4 years, 4 months ago (2016-08-23 23:24:31 UTC) #11
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/md_history/app.html: While running git apply --index -3 -p1; error: patch ...
4 years, 4 months ago (2016-08-23 23:29:03 UTC) #13
tsergeant
4 years, 4 months ago (2016-08-23 23:33:25 UTC) #14
On 2016/08/23 23:29:03, commit-bot: I haz the power wrote:
> Failed to apply patch for chrome/browser/resources/md_history/app.html:
> While running git apply --index -3 -p1;
>   error: patch failed: chrome/browser/resources/md_history/app.html:41
>   Falling back to three-way merge...
>   Applied patch to 'chrome/browser/resources/md_history/app.html' with
> conflicts.
>   U chrome/browser/resources/md_history/app.html
> 
> Patch:       chrome/browser/resources/md_history/app.html
> Index: chrome/browser/resources/md_history/app.html
> diff --git a/chrome/browser/resources/md_history/app.html
> b/chrome/browser/resources/md_history/app.html
> index
>
c39d309661aec01188895f4a8a6742b3ba4494a0..f2924a13d9a09982fdf463f501a22bdf0a5cdfd4
> 100644
> --- a/chrome/browser/resources/md_history/app.html
> +++ b/chrome/browser/resources/md_history/app.html
> @@ -41,6 +41,10 @@
>          float: left;
>        }
>  
> +      :host-context([dir=rtl]) #content-side-bar {
> +        float: right;
> +      }
> +
>        #content,
>        #content > * {
>          height: 100%;

=(

Closing in favor of https://codereview.chromium.org/2268353004/

Powered by Google App Engine
This is Rietveld 408576698