Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2273553003: Deserialize the scope chain for background parsing jobs on the main thread (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deserialize the scope chain for background parsing jobs on the main thread Even though there is no scope chain, just the empty outer scope. R=marja@chromium.org BUG= Committed: https://crrev.com/9a549cc6215f6e5eac4b52e6c977c04ff798cab0 Cr-Commit-Position: refs/heads/master@{#38814}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/background-parsing-task.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-23 10:58:39 UTC) #1
marja
lgtm
4 years, 4 months ago (2016-08-23 10:59:14 UTC) #4
marja
still lgtm
4 years, 4 months ago (2016-08-23 11:04:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273553003/20001
4 years, 4 months ago (2016-08-23 11:04:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 11:46:05 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 11:46:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a549cc6215f6e5eac4b52e6c977c04ff798cab0
Cr-Commit-Position: refs/heads/master@{#38814}

Powered by Google App Engine
This is Rietveld 408576698