base/BUILD.gn - Issue 2273553002: Create BaseJUnitClassRunner to run junit4 style tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 2273553002: Create BaseJUnitClassRunner to run junit4 style tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change after +jbudorick's comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | base/test/android/javatests/src/org/chromium/base/test/BaseJUnit4ClassRunner.java » ('j') | base/test/android/javatests/src/org/chromium/base/test/BaseJUnit4ClassRunner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index 0cf620f37822b6f7bbff001abd065b32e6861a7d..b71d0fb23eea2ae4c0e1df15cb222da69a43e5f5 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -2359,12 +2359,16 @@ if (is_android) {

deps = [

":base_java",

"//testing/android/reporter:reporter_java",

+ "//third_party/android_support_test_runner:exposed_instrumentation_api_publish_java",

+ "//third_party/android_support_test_runner:runner_java",

"//third_party/hamcrest:hamcrest_core_java",

+ "//third_party/junit",

]

java_files = [

"test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java",

"test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java",

"test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java",

+ "test/android/javatests/src/org/chromium/base/test/BaseJUnit4ClassRunner.java",

"test/android/javatests/src/org/chromium/base/test/BaseTestResult.java",

"test/android/javatests/src/org/chromium/base/test/util/AdvancedMockContext.java",

"test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java",