Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2273503003: X87: [interpreter] Fix self-healing with preserved bytecode. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [interpreter] Fix self-healing with preserved bytecode. port 4598d9139e5930543b55bca2154afc966b64c557 (r38747) original commit message: This fixes the self-healing mechanism for closures in the interpreter entry trampoline not that bytecode can be preserved even when baseline code is already available. BUG= Committed: https://crrev.com/60908503ac420cba2b780e720e80b1de04776c2d Cr-Commit-Position: refs/heads/master@{#38856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/builtins/x87/builtins-x87.cc View 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-24 02:01:45 UTC) #2
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-24 02:01:46 UTC) #3
Michael Starzinger
LGTM. Thanks!
4 years, 4 months ago (2016-08-24 07:18:13 UTC) #4
Weiliang
lgtm
4 years, 4 months ago (2016-08-24 07:20:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273503003/1
4 years, 4 months ago (2016-08-24 07:22:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 08:53:06 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 08:53:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60908503ac420cba2b780e720e80b1de04776c2d
Cr-Commit-Position: refs/heads/master@{#38856}

Powered by Google App Engine
This is Rietveld 408576698