Call 'InitializeDynamicBindings()' before gl calls.

Call 'InitializeDynamicBindings()' before gl calls.
Some gl functions have not been bound,if no context created before.

BUG=

Committed: https://crrev.com/87bb10abbc8e476de05f1e28c4c976414cbb075b
Cr-Commit-Position: refs/heads/master@{#415533}

[penghu, 2016-08-24 06:15:51]

Description was changed from

==========
should call 'InitializeDynamicBindings()' before gl calls.

BUG=
==========

to

==========
Call 'InitializeDynamicBindings()' before gl calls.
Some gl functions have not been bound,if no context created before.

BUG=
==========

[penghu, 2016-08-24 06:15:51]

penghu@tencent.com changed reviewers:
+ jamesxwei@tencent.com, kylechar@chromium.org, sievers@chromium.org

[kylechar, 2016-08-25 13:37:22]

https://codereview.chromium.org/2273483004/diff/1/ui/gl/init/gl_factory_andro...
File ui/gl/init/gl_factory_android.cc (right):

https://codereview.chromium.org/2273483004/diff/1/ui/gl/init/gl_factory_andro...
ui/gl/init/gl_factory_android.cc:63: SetCurrent(surface);
Unrelated to your change but it looks like all of the other
GLContext::MakeCurrent() overrides do the SetCurrent/SetRealGLAPi part in the
opposite order:

SetRealGLApi();
SetCurrent(surface);
InitializeDynamicBindings();

Not sure if that is important here? It looks like SetCurrent() can call
SetGLApi() so the order might change things.

[penghu, 2016-08-26 02:25:54]

On 2016/08/25 13:37:22, kylechar wrote:
>
https://codereview.chromium.org/2273483004/diff/1/ui/gl/init/gl_factory_andro...
> File ui/gl/init/gl_factory_android.cc (right):
> 
>
https://codereview.chromium.org/2273483004/diff/1/ui/gl/init/gl_factory_andro...
> ui/gl/init/gl_factory_android.cc:63: SetCurrent(surface);
> Unrelated to your change but it looks like all of the other
> GLContext::MakeCurrent() overrides do the SetCurrent/SetRealGLAPi part in the
> opposite order:
> 
> SetRealGLApi();
> SetCurrent(surface);
> InitializeDynamicBindings();
> 
> Not sure if that is important here? It looks like SetCurrent() can call
> SetGLApi() so the order might change things.

Only if MakeCurrent(NULL),the different order will have different results.
Not sure we can release current context with MakeCurrent(NULL).It seems to be
illegal.
But,it looks better that SetRealGLApi() before SetCurrent(), like other
GLContext::MakeCurrent() overrides.

[penghu, 2016-08-30 01:38:28]

penghu@tencent.com changed reviewers:
+ piman@chromium.org

[piman, 2016-08-30 17:26:13]

lgtm

[penghu, 2016-08-31 01:05:47]

The CQ bit was checked by penghu@tencent.com

[commit-bot: I haz the power, 2016-08-31 01:06:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 01:51:41]

Description was changed from

==========
Call 'InitializeDynamicBindings()' before gl calls.
Some gl functions have not been bound,if no context created before.

BUG=
==========

to

==========
Call 'InitializeDynamicBindings()' before gl calls.
Some gl functions have not been bound,if no context created before.

BUG=
==========

[commit-bot: I haz the power, 2016-08-31 01:51:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-31 01:53:50]

Description was changed from

==========
Call 'InitializeDynamicBindings()' before gl calls.
Some gl functions have not been bound,if no context created before.

BUG=
==========

to

==========
Call 'InitializeDynamicBindings()' before gl calls.
Some gl functions have not been bound,if no context created before.

BUG=

Committed: https://crrev.com/87bb10abbc8e476de05f1e28c4c976414cbb075b
Cr-Commit-Position: refs/heads/master@{#415533}
==========

[commit-bot: I haz the power, 2016-08-31 01:53:53]

Patchset 2 (id:??) landed as
https://crrev.com/87bb10abbc8e476de05f1e28c4c976414cbb075b
Cr-Commit-Position: refs/heads/master@{#415533}